Skip to content

refactor: cleanup shared code #465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 28 commits into from
Oct 16, 2025
Merged

refactor: cleanup shared code #465

merged 28 commits into from
Oct 16, 2025

Conversation

@MrYuion
Copy link
Collaborator

@MrYuion MrYuion commented Sep 21, 2025 •
edited
Loading

Dependencies chains in the code have become a bit convoluted and messy.
This PR makes various changes to fix these issues:

  • Reorganise shared modules to remove cyclic dependencies preventing build optimisations.
  • Make components standalone so their dependencies are explicit.
  • Replace 3rd party HTML editor to an ESM compatible one to improve build optimisations
  • Replace 3rd party YAML lib to an ESM compatible one to improve build optimisations
  • Rewrite mocks so they aren't created in global space, and allow apps to have explicit control over initialisation.

@vercel
Copy link

vercel bot commented Sep 21, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
frontend-templates Ignored Ignored Preview Oct 16, 2025 1:04am

@MrYuion
Merge branch 'develop' into refactor/clean-libs
aa086aa 
# Conflicts:
#	libs/components/src/lib/chat/chat.component.ts
#	libs/components/src/lib/components.module.ts
@MrYuion
chore: remove unneeded module imports
9fa4100
@MrYuion
chore: tweak module imports
0b33dca
@MrYuion
chore: fix import issues
4b525a0
@MrYuion
chore: fix more imports
4f6fa8b
@MrYuion
chore: fix to 2nd previous commit
fa31725
@MrYuion
ci: update PR workflow to handle refactor branches
9e2d430
@MrYuion
Merge branch 'develop' into refactor/clean-libs
79d5495 
# Conflicts:
#	apps/concierge/src/app/day-view/room-approvals.component.ts
#	apps/signage/src/app/media-player.component.ts
#	apps/stagehand/src/app/remote-support.component.ts
#	apps/workplace/src/app/book/parking-flow/parking-flow-form.component.ts
#	libs/components/src/lib/user-controls.component.ts
#	shared/assets/locale/en-AU.json
@MrYuion
chore: fix more issues in concierge and workplace
c3139c6
@MrYuion
chore: minor fixes
8b65bac
@MrYuion
chore: various minor fixes
38318cd
@MrYuion
fix(bookings): fix reading the show_filters state (PPT-2249)
b246127
@MrYuion
chore: tweak imports
e4d9bac
@MrYuion
chore: tweak user pipes
a56eece
@MrYuion
fix(visitor-kiosk): fix bootstrap
b9343fc
@jeremyw24 jeremyw24 self-requested a review October 16, 2025 01:58
jeremyw24
jeremyw24 approved these changes Oct 16, 2025
View reviewed changes
Copy link
Contributor

@jeremyw24 jeremyw24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested all interfaces for any signs of regression and have not been able to identify any issues.

@MrYuion MrYuion merged commit e1a260b into develop Oct 16, 2025
7 of 9 checks passed
@MrYuion MrYuion deleted the refactor/clean-libs branch October 16, 2025 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeremyw24 jeremyw24 jeremyw24 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MrYuion @jeremyw24